Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(366)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
4181041
: Fix caja paramater name
Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by
zhoresh
Modified:
15 years, 1 month ago
Reviewers:
johnfargo
, dev-remailer,
Jasvir
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk
Visibility:
Public.
Description
It seems that the rendering side expect "caja" url paramater while the new url managers produce "cajoled". Update both to use "caja"
Patch Set 1
#
Created:
15 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+22 lines, -19 lines
)
Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java
View
3 chunks
+4 lines, -3 lines
0 comments
Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
View
13 chunks
+17 lines, -15 lines
0 comments
Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriCommon.java
View
1 chunk
+1 line, -1 line
0 comments
Download
Messages
Total messages: 3
Expand All Messages
|
Collapse All Messages
zhoresh
15 years, 1 month ago (2011-02-09 23:06:20 UTC)
#1
Sign in
to reply to this message.
johnfargo
LGTM++ Weird. On 2011/02/09 23:06:20, zhoresh wrote:
15 years, 1 month ago (2011-02-10 20:40:57 UTC)
#2
LGTM++ Weird. On 2011/02/09 23:06:20, zhoresh wrote:
Sign in
to reply to this message.
zhoresh
Thanks. Submitted to r1069563.
15 years, 1 month ago (2011-02-10 20:48:02 UTC)
#3
Thanks. Submitted to r1069563.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 4181041: Fix caja paramater name
Created 15 years, 1 month ago by zhoresh
Modified 15 years, 1 month ago
Reviewers: dev-remailer_shindig.apache.org, Jasvir, johnfargo
Base URL: http://svn.apache.org/repos/asf/shindig/trunk
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b