code review 4174060: 5l/6l/8l: use enums for header type and symbolic string...

src/cmd/6l/pass.c

 // Inferno utils/6l/pass.c
 // http://code.google.com/p/inferno-os/source/browse/utils/6l/pass.c
 //
 //      Copyright © 1994-1999 Lucent Technologies Inc.  All rights reserved.
 //      Portions Copyright © 1995-1997 C H Forsyth (forsyth@terzarima.net)
 //      Portions Copyright © 1997-1999 Vita Nuova Limited
 //      Portions Copyright © 2000-2007 Vita Nuova Holdings Limited (www.vitanuova.com)
 //      Portions Copyright © 2004,2006 Bruce Ellis
 //      Portions Copyright © 2005-2007 C H Forsyth (forsyth@terzarima.net)
 //      Revisions Copyright © 2000-2007 Lucent Technologies Inc. and others
@@ skipping 253 matching lines @@
         Bflush(&bso);
         mkfwd();
         if(debug['v'])
                 Bprint(&bso, "%5.2f patch\n", cputime());
         Bflush(&bso);
 
         s = lookup("exit", 0);
         vexit = s->value;
         for(cursym = textp; cursym != nil; cursym = cursym->next)
         for(p = cursym->text; p != P; p = p->link) {
-                if(HEADTYPE == 10) {·
+                if(HEADTYPE == Hwindows) {·
                         // Windows
                         // Convert
                         //   op   n(GS), reg
                         // to
                         //   MOVL 0x58(GS), reg
                         //   op   n(reg), reg
                         // The purpose of this patch is to fix some accesses
                         // to extern register variables (TLS) on Windows, as
                         // a different method is used to access them.
                         if(p->from.type == D_INDIR+D_GS
                         && p->to.type >= D_AX && p->to.type <= D_DI·
                         && p->from.offset <= 8) {
                                 q = appendp(p);
                                 q->from = p->from;
                                 q->from.type = D_INDIR + p->to.type;
                                 q->to = p->to;
                                 q->as = p->as;
                                 p->as = AMOVQ;
                                 p->from.type = D_INDIR+D_GS;
                                 p->from.offset = 0x58;
                         }
                 }
-                if(HEADTYPE == 7 || HEADTYPE == 9) {
+                if(HEADTYPE == Hlinux || HEADTYPE == Hfreebsd) {
                         // ELF uses FS instead of GS.
                         if(p->from.type == D_INDIR+D_GS)
                                 p->from.type = D_INDIR+D_FS;
                         if(p->to.type == D_INDIR+D_GS)
                                 p->to.type = D_INDIR+D_FS;
                 }
                 if(p->as == ACALL || (p->as == AJMP && p->to.type != D_BRANCH)) {
                         s = p->to.sym;
                         if(s) {
                                 if(debug['c'])
@@ skipping 107 matching lines @@
                         autoffset = 0;
 
                 q = P;
                 q1 = P;
                 if((p->from.scale & NOSPLIT) && autoffset >= StackSmall)
                         diag("nosplit func likely to overflow stack");
 
                 if(!(p->from.scale & NOSPLIT)) {
                         p = appendp(p); // load g into CX
                         p->as = AMOVQ;
-                        if(HEADTYPE == 7 || HEADTYPE == 9)      // ELF uses FS
+                        if(HEADTYPE == Hlinux || HEADTYPE == Hfreebsd)  // ELF uses FS
                                 p->from.type = D_INDIR+D_FS;
                         else
                                 p->from.type = D_INDIR+D_GS;
                         p->from.offset = tlsoffset+0;
                         p->to.type = D_CX;
-                        if(HEADTYPE == 10) { // Windows
+                        if(HEADTYPE == Hwindows) {
                                 // movq %gs:0x58, %rcx
                                 // movq (%rcx), %rcx
                                 p->as = AMOVQ;
                                 p->from.type = D_INDIR+D_GS;
                                 p->from.offset = 0x58;
                                 p->to.type = D_CX;
 
 ························
                                 p = appendp(p);
                                 p->as = AMOVQ;
@@ skipping 281 matching lines @@
 undef(void)
 {
         int i;
         Sym *s;
 
         for(i=0; i<NHASH; i++)
         for(s = hash[i]; s != S; s = s->hash)
                 if(s->type == SXREF)
                         diag("%s: not defined", s->name);
 }