Issue 4172053: Small change to render doctype

gagan.goku

http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java (right): http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java#newcode59 java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java:59: protected String renderDocType(DocumentType docType) { shouldn't this be HtmlSerialization.outputDocType(docType, ...

15 years, 1 month ago (2011-02-17 20:46:36 UTC) #2

Jasvir

http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java (right): http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java#newcode59 java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java:59: protected String renderDocType(DocumentType docType) { I do not understand ...

15 years, 1 month ago (2011-02-17 20:57:19 UTC) #3

gagan.goku

Pardon my lack of knowledge about gadgets. lgtm from my side. http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java (right): ...

15 years, 1 month ago (2011-02-17 21:09:41 UTC) #4

mgmarum

http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java (right): http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java#newcode59 java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java:59: protected String renderDocType(DocumentType docType) { fwiw, the OpenSocial 1.1 ...

15 years, 1 month ago (2011-02-17 21:11:15 UTC) #5

johnfargo

15 years, 1 month ago (2011-02-18 02:22:26 UTC) #6

@Jasvir, perhaps let's make this behavior configurable, on an opt-in basis?

On Thu, Feb 17, 2011 at 1:11 PM, <mgmarum@gmail.com> wrote:

>
>
>
http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/a...
> File
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java
> (right):
>
>
>
http://codereview.appspot.com/4172053/diff/1/java/gadgets/src/main/java/org/a...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java:59:
> protected String renderDocType(DocumentType docType) {
> fwiw, the OpenSocial 1.1 spec currently requires that gadgets be
> rendered in browser quirks mode.
> (
>
http://opensocial-resources.googlecode.com/svn/spec/1.1/Core-Gadget.xml#Rende...
> )
>
>
> We are looking to change that in OpenSocial 2.0.
> (http://docs.opensocial.org/display/OSD/Remove+Quirks+Mode)
>
> And "<!DOCTYPE html>" is the proper declaration for HTML5.
> (http://dev.w3.org/html5/spec/syntax.html#the-doctype)
>
>
> http://codereview.appspot.com/4172053/
>

Sign in to reply to this message.

Issue 4172053: Small change to render doctype (Closed)

Description

Patch Set 1 #

Messages