Issue 4171056: Use lxml instead of minidom for issue1863

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4171056: Use lxml instead of minidom for issue1863 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 12 months ago by ced

Modified:
14 years, 11 months ago

Reviewers:
bch, yangoon, nicoe

Visibility:
Public.

Patch Set 2 : Fix typo #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -34 lines)			Patch
	M	trytond/report/report.py	View	1	4 chunks	+26 lines, -34 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

yangoon

http://codereview.appspot.com/4171056/diff/1/trytond/report/report.py File trytond/report/report.py (right): http://codereview.appspot.com/4171056/diff/1/trytond/report/report.py#newcode197 trytond/report/report.py:197: new_style_tree = lxml.etree.parse(StringIO.StringIO(style2_xml)) new_style_tree = lxml.etree.parse(StringIO.StringIO(new_style_xml))

14 years, 12 months ago (2011-02-16 21:33:39 UTC) #2

LGTM untested

Expand All Messages | Collapse All Messages