Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(215)

Issue 4171044: Fix User Preference Window (issue1858) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by nicoe
Modified:
14 years, 11 months ago
Reviewers:
yangoon, ced
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use display instead of switch view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tryton/gui/window/preference.py View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6
nicoe
15 years ago (2011-02-10 18:19:10 UTC) #1
ced
http://codereview.appspot.com/4171044/diff/1/tryton/gui/window/preference.py File tryton/gui/window/preference.py (right): http://codereview.appspot.com/4171044/diff/1/tryton/gui/window/preference.py#newcode66 tryton/gui/window/preference.py:66: self.screen.current_record.validate(softvalidation=True) I'm not sure we need a validation there. ...
15 years ago (2011-02-11 09:15:39 UTC) #2
yangoon
15 years ago (2011-02-11 11:08:48 UTC) #3
nicoe
14 years, 12 months ago (2011-02-16 14:55:38 UTC) #4
nicoe
http://codereview.appspot.com/4171044/diff/1/tryton/gui/window/preference.py File tryton/gui/window/preference.py (right): http://codereview.appspot.com/4171044/diff/1/tryton/gui/window/preference.py#newcode66 tryton/gui/window/preference.py:66: self.screen.current_record.validate(softvalidation=True) On 2011/02/11 09:15:39, ced wrote: > I'm not ...
14 years, 12 months ago (2011-02-16 14:57:21 UTC) #5
ced
14 years, 12 months ago (2011-02-16 16:53:34 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b