Use LC_CTYPE instead of LC_MESSAGES in bus_ibus_impl_set_default_preload_engines.

Use LC_CTYPE instead of LC_MESSAGES in bus_ibus_impl_set_default_preload_engines.

[Peng, 2011-02-17 12:44:33]

http://codereview.appspot.com/4167053/diff/1/bus/ibusimpl.c
File bus/ibusimpl.c (right):

http://codereview.appspot.com/4167053/diff/1/bus/ibusimpl.c#newcode527
bus/ibusimpl.c:527: gchar *lang = g_strdup (setlocale (LC_CTYPE, NULL));
Why change to LC_CTYPE?

[Yusuke Sato, 2011-02-17 12:46:18]

http://codereview.appspot.com/4167053/diff/1/bus/ibusimpl.c
File bus/ibusimpl.c (right):

http://codereview.appspot.com/4167053/diff/1/bus/ibusimpl.c#newcode527
bus/ibusimpl.c:527: gchar *lang = g_strdup (setlocale (LC_CTYPE, NULL));
On 2011/02/17 12:44:33, Shawn.P.Huang wrote:
> Why change to LC_CTYPE?

Per Fujiwara-san's suggestion at
http://code.google.com/p/ibus/issues/detail?id=1204

[fujiwara, 2011-02-17 15:40:20]

On 2011/02/17 12:44:33, Shawn.P.Huang wrote:
> Why change to LC_CTYPE?

Many users still use LC_MESSAGES=C/POSIX and many implementations use LC_CTYPE
instead.

[Peng, 2011-02-17 15:49:53]

On 2011/02/17 15:40:20, fujiwara wrote:
> On 2011/02/17 12:44:33, Shawn.P.Huang wrote:
> > Why change to LC_CTYPE?
> 
> Many users still use LC_MESSAGES=C/POSIX and many implementations use LC_CTYPE
> instead.

IMHO, the selected input method should be same with the language for UI. It is
more reasonable. Right?

[fujiwara, 2011-02-17 15:53:22]

On 2011/02/17 15:49:53, Shawn.P.Huang wrote:
> IMHO, the selected input method should be same with the language for UI. It is
> more reasonable. Right?

The most language UI would use LANG not LC_MESSAGES.

[Peng, 2011-02-17 16:14:00]

On 2011/02/17 15:53:22, fujiwara wrote:
> On 2011/02/17 15:49:53, Shawn.P.Huang wrote:
> > IMHO, the selected input method should be same with the language for UI. It
is
> > more reasonable. Right?
> 
> The most language UI would use LANG not LC_MESSAGES.

I see. But if LANG and LC_MESSAGES are both set. UI will use LC_MESSAGES. If it
doesn't exist, UI will use value from LANG.

setlocale(LC_MESSAGES, NULL) will return LC_ALL or LC_MESSAGES or LANG. The fist
exist variable will be returned. I think it is we want. right?

[fujiwara, 2011-02-17 16:24:48]

On 2011/02/17 16:14:00, Shawn.P.Huang wrote:
> I see. But if LANG and LC_MESSAGES are both set. UI will use LC_MESSAGES. 

UI is not GUI translation.
If LANG and LC_MESSAGES are set, I think LANG should be used for IM and fonts.
I think your usage chould resolve with setting LANG only.
I think it would be trouble especially for enterprise users which like to use
applications with English messages.
I had received several esculations/bugs about this kind of problems.

[Peng, 2011-02-17 17:39:47]

After offline discuss with fujiwara. This CL is LGTM.


On 2011/02/17 16:14:00, Shawn.P.Huang wrote:
> On 2011/02/17 15:53:22, fujiwara wrote:
> > On 2011/02/17 15:49:53, Shawn.P.Huang wrote:
> > > IMHO, the selected input method should be same with the language for UI.
It
> is
> > > more reasonable. Right?
> > 
> > The most language UI would use LANG not LC_MESSAGES.
> 
> I see. But if LANG and LC_MESSAGES are both set. UI will use LC_MESSAGES. If
it
> doesn't exist, UI will use value from LANG.
> 
> setlocale(LC_MESSAGES, NULL) will return LC_ALL or LC_MESSAGES or LANG. The
fist
> exist variable will be returned. I think it is we want. right?

[Yusuke Sato, 2011-02-18 01:26:35]

I found he's already implemented this. I've cherry-picked it:
https://github.com/fujiwarat/ibus/commit/3eb06885638e36058f4e1fb40a702846e6ec...

On 2011/02/17 17:39:47, Peng wrote:
> After offline discuss with fujiwara. This CL is LGTM.
> 
> 
> On 2011/02/17 16:14:00, Shawn.P.Huang wrote:
> > On 2011/02/17 15:53:22, fujiwara wrote:
> > > On 2011/02/17 15:49:53, Shawn.P.Huang wrote:
> > > > IMHO, the selected input method should be same with the language for UI.
> It
> > is
> > > > more reasonable. Right?
> > > 
> > > The most language UI would use LANG not LC_MESSAGES.
> > 
> > I see. But if LANG and LC_MESSAGES are both set. UI will use LC_MESSAGES. If
> it
> > doesn't exist, UI will use value from LANG.
> > 
> > setlocale(LC_MESSAGES, NULL) will return LC_ALL or LC_MESSAGES or LANG. The
> fist
> > exist variable will be returned. I think it is we want. right?

[fujiwara, 2011-02-18 01:32:15]

On 2011/02/18 01:26:35, Yusuke Sato wrote:
> I found he's already implemented this. I've cherry-picked it:
>
https://github.com/fujiwarat/ibus/commit/3eb06885638e36058f4e1fb40a702846e6ec...

Thanks for the integration.