Issue 4154044: Handle maximize on client (Closed)
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove unneeded bool #
MessagesTotal messages: 14
lgtm, But I'm not sure if it would be better to activate the funktionality for windows only. http://codereview.appspot.com/4154044/diff/1/tryton/gui/main.py File tryton/gui/main.py (right): http://codereview.appspot.com/4154044/diff/1/tryton/gui/main.py#newcode1340 tryton/gui/main.py:1340: gtk.gdk.WINDOW_STATE_MAXIMIZED) Ich bevorzuge explizit: CONFIG['client.maximize'] = False if event.new_window_state == gtk.gdk.WINDOW_STATE_MAXIMIZED: CONFIG['client.maximize'] = True
Sign in to reply to this message.
Should not it be the job of the window manager?
Sign in to reply to this message.
On 2011/02/17 09:53:58, ced wrote: > Should not it be the job of the window manager? The Problem is: How should the windows manager know that the windows was maximized last time? When the user maximizes the window and then closes the client und restarts the client there is no info that the windows was maximized last time.
Sign in to reply to this message.
Sign in to reply to this message.
On 2011/02/17 10:04:16, timitos3000 wrote: > On 2011/02/17 09:53:58, ced wrote: > > Should not it be the job of the window manager? > > The Problem is: How should the windows manager know that the windows was > maximized last time? When the user maximizes the window and then closes the > client und restarts the client there is no info that the windows was maximized > last time. The window manager can know. It is his job to put the window at the right place.
Sign in to reply to this message.
On 2011/02/17 10:06:20, ced wrote: > On 2011/02/17 10:04:16, timitos3000 wrote: > > On 2011/02/17 09:53:58, ced wrote: > > > Should not it be the job of the window manager? > > > > The Problem is: How should the windows manager know that the windows was > > maximized last time? When the user maximizes the window and then closes the > > client und restarts the client there is no info that the windows was maximized > > last time. > > The window manager can know. It is his job to put the window at the right place. This does not work on windows for now. This is a solution to solve this. If it is not the correct way you maybe have a hint to how to solve this problem in a correct way.
Sign in to reply to this message.
Sign in to reply to this message.
On 2011/02/17 10:14:33, timitos3000 wrote: > On 2011/02/17 10:06:20, ced wrote: > > On 2011/02/17 10:04:16, timitos3000 wrote: > > > On 2011/02/17 09:53:58, ced wrote: > > > > Should not it be the job of the window manager? > > > > > > The Problem is: How should the windows manager know that the windows was > > > maximized last time? When the user maximizes the window and then closes the > > > client und restarts the client there is no info that the windows was > maximized > > > last time. > > > > The window manager can know. It is his job to put the window at the right > place. > > This does not work on windows for now. This is a solution to solve this. If it > is not the correct way you maybe have a hint to how to solve this problem in a > correct way. My concern is to not bloat the client with behavior that it should not manage.
Sign in to reply to this message.
On 2011/02/17 10:23:56, ced wrote: > On 2011/02/17 10:14:33, timitos3000 wrote: > > On 2011/02/17 10:06:20, ced wrote: > > > On 2011/02/17 10:04:16, timitos3000 wrote: > > > > On 2011/02/17 09:53:58, ced wrote: > > > > > Should not it be the job of the window manager? > > > > > > > > The Problem is: How should the windows manager know that the windows was > > > > maximized last time? When the user maximizes the window and then closes > the > > > > client und restarts the client there is no info that the windows was > > maximized > > > > last time. > > > > > > The window manager can know. It is his job to put the window at the right > > place. > > > > This does not work on windows for now. This is a solution to solve this. If it > > is not the correct way you maybe have a hint to how to solve this problem in a > > correct way. > > My concern is to not bloat the client with behavior that it should not manage. On the other hand the user experience on windows is disappointing for the moment without this patch.
Sign in to reply to this message.
Sign in to reply to this message.
Ok let's go with this as we already get windows size rember http://codereview.appspot.com/4154044/diff/1/tryton/gui/main.py File tryton/gui/main.py (right): http://codereview.appspot.com/4154044/diff/1/tryton/gui/main.py#newcode1339 tryton/gui/main.py:1339: CONFIG['client.maximize'] = bool(event.new_window_state == No need for bool
Sign in to reply to this message.
On 2011/02/17 10:23:56, ced wrote: > On 2011/02/17 10:14:33, timitos3000 wrote: > > On 2011/02/17 10:06:20, ced wrote: > > > On 2011/02/17 10:04:16, timitos3000 wrote: > > > > On 2011/02/17 09:53:58, ced wrote: > > > > > Should not it be the job of the window manager? > > > > > > > > The Problem is: How should the windows manager know that the windows was > > > > maximized last time? When the user maximizes the window and then closes > the > > > > client und restarts the client there is no info that the windows was > > maximized > > > > last time. > > > > > > The window manager can know. It is his job to put the window at the right > > place. > > > > This does not work on windows for now. This is a solution to solve this. If it > > is not the correct way you maybe have a hint to how to solve this problem in a > > correct way. > > My concern is to not bloat the client with behavior that it should not manage. Maybe the problem ist the default height and width that is managed by the client. maybe it must be removed too?
Sign in to reply to this message.
On 2011/02/17 10:34:49, timitos3000 wrote: > On 2011/02/17 10:23:56, ced wrote: > > On 2011/02/17 10:14:33, timitos3000 wrote: > > > On 2011/02/17 10:06:20, ced wrote: > > > > On 2011/02/17 10:04:16, timitos3000 wrote: > > > > > On 2011/02/17 09:53:58, ced wrote: > > > > > > Should not it be the job of the window manager? > > > > > > > > > > The Problem is: How should the windows manager know that the windows was > > > > > maximized last time? When the user maximizes the window and then closes > > the > > > > > client und restarts the client there is no info that the windows was > > > maximized > > > > > last time. > > > > > > > > The window manager can know. It is his job to put the window at the right > > > place. > > > > > > This does not work on windows for now. This is a solution to solve this. If > it > > > is not the correct way you maybe have a hint to how to solve this problem in > a > > > correct way. > > > > My concern is to not bloat the client with behavior that it should not manage. > > Maybe the problem ist the default height and width that is managed by the > client. maybe it must be removed too? i did not find a better solution. i will put the final patch on the bug tracker.
Sign in to reply to this message.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
