[PATCH] Add CMake support to the clang unittests

unittests/CMakeLists.txt is mostly a copy of llvm's unittests/CMakeLists.txt, with some changes to adapt it to clang. I don't know CMake well enough to know if some pieces can be factored out.

[Jeffrey Yasskin, 2011-02-09 19:36:29]

Initial patch at http://codereview.appspot.com/download/issue4152043_1.diff

[chapuni, 2011-02-10 04:19:49]

Jeffrey, thank you to work on!

I can build and run FrontendTests to add some libs.

--- a/unittests/CMakeLists.txt
+++ b/unittests/CMakeLists.txt
@@ -46,10 +46,11 @@ set(LLVM_LINK_COMPONENTS
 set(LLVM_USED_LIBS
   gtest
   gtest_main
-  LLVMSupport # gtest needs it for raw_ostream.
-  clangAST
   clangFrontend
   clangSerialization
+  clangAST
+  clangLex
+  clangBasic
   )

 add_clang_unittest(Frontend

I have confirmed on CentOS5, msys-mingw and msvs10.

A matter. With this patch, "standalone clang with cmake" cannot be built.
gtest headers would be needed. Any idea? For now disabling unittests
on standalone clang?

...Takumi

[chapuni, 2011-02-10 06:21:55]

Jeffrey, here is an additional patch, to suppress unittests for now.

Checked on centos5.

...Takumi

[Jeffrey Yasskin, 2011-02-10 07:01:18]

Thanks! An updated patch is at
http://codereview.appspot.com/download/issue4152043_5001.diff. I haven't
double-checked that it works on Mac or with a pre-installed LLVM yet.

On 2011/02/10 06:21:55, chapuni wrote:
> Jeffrey, here is an additional patch, to suppress unittests for now.
> 
> Checked on centos5.
> 
> ...Takumi

[Jeffrey Yasskin, 2011-02-12 01:45:48]

I split the dependency changes out into r125417, so here's an updated patch with
just the unittest changes:
http://codereview.appspot.com/download/issue4152043_13001.diff

I've now tested on Linux in both normal and standalone modes, and on Mac in the
normal mode.

On 2011/02/10 07:01:18, Jeffrey Yasskin wrote:
> Thanks! An updated patch is at
> http://codereview.appspot.com/download/issue4152043_5001.diff. I haven't
> double-checked that it works on Mac or with a pre-installed LLVM yet.
> 
> On 2011/02/10 06:21:55, chapuni wrote:
> > Jeffrey, here is an additional patch, to suppress unittests for now.
> > 
> > Checked on centos5.
> > 
> > ...Takumi

[chapuni, 2011-02-12 01:49:38]

Jeffrey, LGTM, thank you!

...Takumi

[Jeffrey Yasskin, 2011-02-15 02:06:22]

Óscar, could you take a look at this, or say that Takumi's LGTM is enough?

The Rietveld issue is at http://codereview.appspot.com/4152043/, and
the most recent patch is at
http://codereview.appspot.com/download/issue4152043_13001.diff.

Thanks!
Jeffrey

On Fri, Feb 11, 2011 at 5:49 PM, NAKAMURA Takumi <geek4civic@gmail.com> wrote:
> Jeffrey, LGTM, thank you!
>
> ...Takumi
>

[ofv_wanadoo.es, 2011-02-15 02:32:08]

Jeffrey Yasskin <jyasskin@gmail.com> writes:

> Óscar, could you take a look at this, or say that Takumi's LGTM is
> enough?

Yes, Takumi's opinion is enough when the change is restricted to the
tests/unittests part of the CMake build. He is more familiar with that
code than me.

[snip]