Issue 4137041: Set filename of binary field on another field (server patch)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4137041: Set filename of binary field on another field (server patch) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by nicoe

Modified:
14 years, 12 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : update depends #

Total comments: 1

Patch Set 3 : Added filename_visible attribute to xml #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -11 lines)			Patch
M	trytond/ir/attachment.py	View	1 2	1 chunk	+3 lines, -4 lines	0 comments	Download
M	trytond/ir/ui/form.rnc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trytond/ir/ui/form.rng	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	trytond/model/fields/binary.py	View	1 2	1 chunk	+11 lines, -6 lines	0 comments	Download
M	trytond/model/model.py	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/4137041/diff/1/trytond/model/fields/binary.py File trytond/model/fields/binary.py (right): http://codereview.appspot.com/4137041/diff/1/trytond/model/fields/binary.py#newcode22 trytond/model/fields/binary.py:22: self.file_name = file_name file_name must be added to depends

15 years ago (2011-02-07 19:17:23 UTC) #3

nicoe

15 years ago (2011-02-08 11:53:34 UTC) #4

ced

http://codereview.appspot.com/4137041/diff/7001/trytond/model/fields/binary.py File trytond/model/fields/binary.py (right): http://codereview.appspot.com/4137041/diff/7001/trytond/model/fields/binary.py#newcode18 trytond/model/fields/binary.py:18: self.file_name = file_name self.file_name should have a default value ...

15 years ago (2011-02-08 22:24:01 UTC) #6

Expand All Messages | Collapse All Messages