Issue 41330044: issue404

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 41330044: issue404

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Silvan S

Modified:
12 years ago

Reviewers:
malte.helmert

Visibility:
Public.

More Reviews

Patch Set 2 : separate evaluation and test #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
M	src/search/pdbs/canonical_pdbs_heuristic.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/search/pdbs/canonical_pdbs_heuristic.cc	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download
M	src/search/pdbs/pattern_generation_haslum.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

malte.helmert

https://codereview.appspot.com/41330044/diff/1/src/search/pdbs/canonical_pdbs_heuristic.h File src/search/pdbs/canonical_pdbs_heuristic.h (right): https://codereview.appspot.com/41330044/diff/1/src/search/pdbs/canonical_pdbs_heuristic.h#newcode56 src/search/pdbs/canonical_pdbs_heuristic.h:56: bool dead_end(const State &state) const; The comment is good, ...

12 years ago (2013-12-30 18:53:17 UTC) #2

Expand All Messages | Collapse All Messages