code review 4131045: template: allow a leading '*' to indicate that evaulati...

template: allow a leading '*' to indicate that evaulation should
indirect through a pointer.

Fixes issue 1478.

[r, 2011-02-04 22:59:06]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-02-04 23:06:31]

LGTM

http://codereview.appspot.com/4131045/diff/1/src/pkg/template/template.go
File src/pkg/template/template.go (right):

http://codereview.appspot.com/4131045/diff/1/src/pkg/template/template.go#new...
src/pkg/template/template.go:60: value of the underlying integer.
Describe behavior on nil, non-pointer.

http://codereview.appspot.com/4131045/diff/1/src/pkg/template/template.go#new...
src/pkg/template/template.go:606: // but are left in place if the name is used
as a map key.
appears not to be true (good)

[r2, 2011-02-04 23:08:29]

On Feb 4, 2011, at 3:06 PM, rsc@golang.org wrote:

> LGTM
> 
> 
> 
> http://codereview.appspot.com/4131045/diff/1/src/pkg/template/template.go
> File src/pkg/template/template.go (right):
> 
>
http://codereview.appspot.com/4131045/diff/1/src/pkg/template/template.go#new...
> src/pkg/template/template.go:60: value of the underlying integer.
> Describe behavior on nil, non-pointer.
> 
>
http://codereview.appspot.com/4131045/diff/1/src/pkg/template/template.go#new...
> src/pkg/template/template.go:606: // but are left in place if the name
> is used as a map key.
> appears not to be true (good)

that was a dreg from my first attempt. i have deleted that sentence.

> 
> http://codereview.appspot.com/4131045/

[r, 2011-02-04 23:21:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=aa76041bc64d ***

template: allow a leading '*' to indicate that evaulation should
indirect through a pointer.

Fixes issue 1478.

R=rsc, r2
CC=golang-dev
http://codereview.appspot.com/4131045