Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(206)

Issue 4129051: Change xhr to survive uriPolicy returning null instead of undefined (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by Jasvir
Modified:
15 years, 1 month ago
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The uri policy may return falsy values other than undefined (for example null). The test in xhr should only use the value return by the url policy if it is a string. I considered testing for falsy but "" may be a valid uri for the policy to return. @4367

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change xhr to survive uriPolicy returning null instead of undefined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/com/google/caja/demos/playground/taming.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/domita.js View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Jasvir
15 years, 2 months ago (2011-02-04 18:27:15 UTC) #1
Mark S. Miller
http://codereview.appspot.com/4129051/diff/1/src/com/google/caja/demos/playground/taming.js File src/com/google/caja/demos/playground/taming.js (right): http://codereview.appspot.com/4129051/diff/1/src/com/google/caja/demos/playground/taming.js#newcode38 src/com/google/caja/demos/playground/taming.js:38: if (!/^https?:\/\//i.test(uri)) { return undefined; } void 0 ?
15 years, 2 months ago (2011-02-04 18:56:25 UTC) #2
Jasvir
http://codereview.appspot.com/4129051/diff/1/src/com/google/caja/demos/playground/taming.js File src/com/google/caja/demos/playground/taming.js (right): http://codereview.appspot.com/4129051/diff/1/src/com/google/caja/demos/playground/taming.js#newcode38 src/com/google/caja/demos/playground/taming.js:38: if (!/^https?:\/\//i.test(uri)) { return undefined; } On 2011/02/04 18:56:25, ...
15 years, 2 months ago (2011-02-04 18:58:21 UTC) #3
Jasvir
ping
15 years, 1 month ago (2011-02-08 11:50:01 UTC) #4
Mark S. Miller
15 years, 1 month ago (2011-02-08 15:25:13 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b