Issue 4128064: code review 4128064: asn1: marhall true as 255, not 1.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4128064: code review 4128064: asn1: marhall true as 255, not 1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by agl1

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

asn1: marshal true as 255, not 1. OS X, at least, appears to test |byte == 255|, not |byte != 0| to establish if a bool is true or false.

Patch Set 1 #

Patch Set 2 : diff -r b5d17ce5197c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b5d17ce5197c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ab944f788448 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ab944f788448 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/asn1/marshal.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-02-05 15:30:04 UTC) #1

agl1

On Sat, Feb 5, 2011 at 10:30 AM, <agl@golang.org> wrote: > asn1: marhall true as ...

14 years, 1 month ago (2011-02-05 15:59:01 UTC) #2

agl1

14 years, 1 month ago (2011-02-05 18:55:44 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=261bbeb33698 ***

asn1: marshal true as 255, not 1.

OS X, at least, appears to test |byte == 255|, not |byte != 0| to
establish if a bool is true or false.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4128064

Expand All Messages | Collapse All Messages