Issue 4127051: code review 4127051: loader: move the XputY routines into the ld directory.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4127051: code review 4127051: loader: move the XputY routines into the ld directory. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by r

Modified:
14 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

loader: move the XputY routines into the ld directory. Fixes the build for 5l, and also removes an inconsequential bug in 8l.

Patch Set 1 #

Patch Set 2 : diff -r 8b230b95b70b https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -108 lines)			Patch
M	src/cmd/5l/asm.c	View	2 chunks	+0 lines, -21 lines	0 comments	Download
M	src/cmd/5l/l.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6l/asm.c	View	1 chunk	+0 lines, -46 lines	0 comments	Download
M	src/cmd/6l/l.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8l/asm.c	View	1 chunk	+0 lines, -39 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/cmd/ld/symtab.c	View	1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-02-07 22:23:36 UTC) #1

14 years, 1 month ago (2011-02-07 22:34:24 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=68f660624fd2 ***

loader: move the XputY routines into the ld directory.
Fixes the build for 5l, and also removes an inconsequential bug in 8l.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4127051

Expand All Messages | Collapse All Messages