code review 4125046: regexp: add support for matching text read from things ...

regexp: add support for matching text read from things that implement
ReadRune.  (If you have a Reader but not a RuneReader, use bufio.)

The matching code is a few percent slower but significantly cleaner.

[r, 2011-02-02 22:03:32]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-02-03 21:48:04]

LGTM

http://codereview.appspot.com/4125046/diff/1/src/pkg/regexp/regexp.go
File src/pkg/regexp/regexp.go (right):

http://codereview.appspot.com/4125046/diff/1/src/pkg/regexp/regexp.go#newcode754
src/pkg/regexp/regexp.go:754: canPeek() bool                      // can we look
ahead without losing info?
s/canPeek/canCheckPrefix/ ?

http://codereview.appspot.com/4125046/diff/1/src/pkg/regexp/regexp.go#newcode772
src/pkg/regexp/regexp.go:772: return endOfText, 1
not endOfText, 0 ?
etc

[r, 2011-02-03 21:54:22]

http://codereview.appspot.com/4125046/diff/1/src/pkg/regexp/regexp.go
File src/pkg/regexp/regexp.go (right):

http://codereview.appspot.com/4125046/diff/1/src/pkg/regexp/regexp.go#newcode754
src/pkg/regexp/regexp.go:754: canPeek() bool                      // can we look
ahead without losing info?
On 2011/02/03 21:48:04, rsc wrote:
> s/canPeek/canCheckPrefix/ ?

Done.

http://codereview.appspot.com/4125046/diff/1/src/pkg/regexp/regexp.go#newcode772
src/pkg/regexp/regexp.go:772: return endOfText, 1
On 2011/02/03 21:48:04, rsc wrote:
> not endOfText, 0 ?
> etc

no, it needs to be 1. will add a comment.

[r, 2011-02-03 21:58:06]

http://codereview.appspot.com/4125046/diff/1/src/pkg/regexp/regexp.go
File src/pkg/regexp/regexp.go (right):

http://codereview.appspot.com/4125046/diff/1/src/pkg/regexp/regexp.go#newcode772
src/pkg/regexp/regexp.go:772: return endOfText, 1
you're right after all. the 1 was to work around a problem i fixed just before
sending it out.

[r, 2011-02-03 21:58:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=f37c651d8774 ***

regexp: add support for matching text read from things that implement
ReadRune.  (If you have a Reader but not a RuneReader, use bufio.)

The matching code is a few percent slower but significantly cleaner.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4125046