code review 4124054: crypto/openpgp/packet: two more packet types.

crypto/openpgp/packet: two more packet types.

[bradfitz, 2011-02-04 18:34:24]

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/private_key.go (right):

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/private_key.go:21: // PrivateKey represents a,
possibly encrypted, private key. See RFC 4880,
Sentence reads weird.  Maybe move ", possibly encrypted" to the end?

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/private_key.go:51: case 254, 255:
private readable constants for these?

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/private_key.go:77: return nil
return or "return nil"?

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/userid.go (right):

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/userid.go:15: // takes the form "Full Name
(Comment) <email@example.com>"
accessor methods on this struct to parse that convention?

Or parse it if recognized into Name, Command, and Email fields on the struct?

[r, 2011-02-04 21:01:58]

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/private_key.go (right):

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/private_key.go:21: // PrivateKey represents a,
possibly encrypted, private key. See RFC 4880,
On 2011/02/04 18:34:28, bradfitzgo wrote:
> Sentence reads weird.  Maybe move ", possibly encrypted" to the end?

just delete the commas

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/private_key.go:29: PrivateKey    interface{} // A
*rsa.PrivateKey for now.
s/A/An/?
what does 'for now' mean?

http://codereview.appspot.com/4124054/diff/2001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/private_key.go:66: return
error.UnsupportedError("deprecated private key s2k")
i think the message isn't right.
deprecated type for private s2k key?

[agl1, 2011-02-05 17:06:41]

Hello bradfitzgo, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[agl1, 2011-02-05 17:10:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=5b014ff57c09 ***

crypto/openpgp/packet: two more packet types.

R=bradfitzgo, r
CC=golang-dev
http://codereview.appspot.com/4124054