code review 4124041: fix windows build

fix windows build

[vcc, 2011-01-29 03:38:28]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-01-29 04:43:39]

LGTM

Sorry for the trouble.

[rsc, 2011-01-29 04:44:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=2082c7c28e9e ***

fix windows build

R=rsc
CC=golang-dev
http://codereview.appspot.com/4124041

Committer: Russ Cox <rsc@golang.org>

[brainman, 2011-01-29 11:55:10]

LGTM. Thank you.

Russ, I don't think we're executing SysReserve yet, because, I think it would
fail during runtime. It needs to be:

runtime·SysReserve(void *v, uintptr n)
{
 	return runtime·stdcall(runtime·VirtualAlloc, 4, v, n, MEM_RESERVE,
PAGE_EXECUTE_READWRITE);
}

[rsc, 2011-01-30 17:20:01]

On Sat, Jan 29, 2011 at 06:55,  <alex.brainman@gmail.com> wrote:
> LGTM. Thank you.
>
> Russ, I don't think we're executing SysReserve yet, because, I think it
> would fail during runtime. It needs to be:
>
> runtime·SysReserve(void *v, uintptr n)
> {
>        return runtime·stdcall(runtime·VirtualAlloc, 4, v, n, MEM_RESERVE,
> PAGE_EXECUTE_READWRITE);
> }

Thanks.  Will fix.  It would only be executed on 64-bit so far,
so you're right that it's not being called.

Russ

[rsc, 2011-01-31 19:33:14]

> runtime·SysReserve(void *v, uintptr n)
> {
>        return runtime·stdcall(runtime·VirtualAlloc, 4, v, n, MEM_RESERVE,
> PAGE_EXECUTE_READWRITE);

Are you sure?

I am reserving the address space, not mapping it,
so I don't want any permissions set on the region.
It's possible that Windows is finicky about this,
but it seemed to me that passing 0 would be okay
since I am not including the MEM_COMMIT flag.

Russ