Issue 4121048: code review 4121048: cgo: os/arch dependent #cgo directives

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4121048: code review 4121048: cgo: os/arch dependent #cgo directives (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by niemeyer

Modified:
14 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cgo: os/arch dependent #cgo directives This enables #cgo directives to contain a os/arch specification which restricts the definition of the given option to matching systems. For example: #cgo amd64 CFLAGS: -DAMD64=1 #cgo linux CFLAGS: -DLINUX=1 #cgo linux/amd64 CFLAGS: -DLINUX_ON_AMD64=1

Patch Set 1 #

Patch Set 2 : code review 4121048: cgo: os/arch dependent #cgo directives #

Patch Set 3 : code review 4121048: cgo: os/arch dependent #cgo directives #

Patch Set 4 : code review 4121048: cgo: os/arch dependent #cgo directives #

Patch Set 5 : code review 4121048: cgo: os/arch dependent #cgo directives #

Total comments: 2

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	src/cmd/cgo/doc.go	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
	M	src/cmd/cgo/gcc.go	View		3 chunks	+23 lines, -2 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 2 months ago (2011-02-01 22:07:29 UTC) #1

rsc

LGTM http://codereview.appspot.com/4121048/diff/1002/src/cmd/cgo/gcc.go File src/cmd/cgo/gcc.go (right): http://codereview.appspot.com/4121048/diff/1002/src/cmd/cgo/gcc.go#newcode85 src/cmd/cgo/gcc.go:85: var k string k := kf[len(kf)-1] no?

14 years, 2 months ago (2011-02-03 04:22:24 UTC) #2

niemeyer

http://codereview.appspot.com/4121048/diff/1002/src/cmd/cgo/gcc.go File src/cmd/cgo/gcc.go (right): http://codereview.appspot.com/4121048/diff/1002/src/cmd/cgo/gcc.go#newcode85 src/cmd/cgo/gcc.go:85: var k string > k := kf[len(kf)-1] no? The ...

14 years, 2 months ago (2011-02-03 11:59:32 UTC) #3

rsc

14 years, 2 months ago (2011-02-03 18:51:49 UTC) #5

*** Submitted as e0e30925d60d ***

cgo: os/arch dependent #cgo directives

This enables #cgo directives to contain a os/arch
specification which restricts the definition of
the given option to matching systems.

For example:

#cgo amd64 CFLAGS: -DAMD64=1
#cgo linux CFLAGS: -DLINUX=1
#cgo linux/amd64 CFLAGS: -DLINUX_ON_AMD64=1

R=rsc
CC=golang-dev
http://codereview.appspot.com/4121048

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages