Issue 4121043: code review 4121043: unicode: build maketables during build, take 2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4121043: code review 4121043: unicode: build maketables during build, take 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by rsc

Modified:
14 years, 1 month ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

unicode: build maketables during build, take 2 The "all:" target is the default for running gomake by hand, but it is not used during the build. The build runs make install and make test. Save the build of maketables for the test phase so that the packages it needs will have been installed already.

Patch Set 1 #

Patch Set 2 : code review 4121043: unicode: build maketables during build, take 2 #

Patch Set 3 : code review 4121043: unicode: build maketables during build, take 2 #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/pkg/unicode/Makefile	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 1 month ago (2011-01-30 22:46:41 UTC) #1

rsc

14 years, 1 month ago (2011-01-31 16:50:08 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4a86edecda56 ***

unicode: build maketables during build, take 2

The "all:" target is the default for running gomake
by hand, but it is not used during the build.
The build runs make install and make test.

Save the build of maketables for the test phase
so that the packages it needs will have been
installed already.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/4121043

Expand All Messages | Collapse All Messages