Issue 4119057: code review 4119057: crypto/tls: load a chain of certificates from a file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4119057: code review 4119057: crypto/tls: load a chain of certificates from a file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by agl1

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, r2

Visibility:
Public.

Description

crypto/tls: load a chain of certificates from a file. Many recently issued certificates are chained: there's one or more intermediate certificates between the host certificate and the root CA certificate. This change causes the code to load any number of certificates from the certificate file. This matches the behaviour of common webservers, and the output of OpenSSL's command line tools.

Patch Set 1 #

Patch Set 2 : diff -r b5d17ce5197c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b5d17ce5197c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b5d17ce5197c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 5b014ff57c09 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	src/pkg/crypto/tls/tls.go	View	1 2	2 chunks	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-02-05 15:36:14 UTC) #1

agl1

14 years, 1 month ago (2011-02-05 18:54:37 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ab944f788448 ***

crypto/tls: load a chain of certificates from a file.

Many recently issued certificates are chained: there's one or more
intermediate certificates between the host certificate and the root CA
certificate. This change causes the code to load any number of
certificates from the certificate file. This matches the behaviour of
common webservers, and the output of OpenSSL's command line tools.

R=golang-dev, r2
CC=golang-dev
http://codereview.appspot.com/4119057

Expand All Messages | Collapse All Messages