Issue 4119047: code review 4119047: run.bash: disable doc/codelab/wiki test on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4119047: code review 4119047: run.bash: disable doc/codelab/wiki test on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by brainman

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

run.bash: disable doc/codelab/wiki test on windows

Patch Set 1 #

Patch Set 2 : code review 4119047: run.bash: disable doc/codelab/wiki test on windows #

Patch Set 3 : code review 4119047: run.bash: disable doc/codelab/wiki test on windows #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/run.bash	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 1 month ago (2011-01-31 04:36:29 UTC) #1

adg

LGTM At some point it would be nice to store the value of this expression ...

14 years, 1 month ago (2011-01-31 04:52:20 UTC) #2

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=385df9242526 *** run.bash: disable doc/codelab/wiki test on windows R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/4119047

14 years, 1 month ago (2011-01-31 04:58:52 UTC) #3

brainman

14 years, 1 month ago (2011-01-31 04:59:10 UTC) #4

On 2011/01/31 04:52:20, adg wrote:
> LGTM

Thahk you for review.

> At some point it would be nice to store the value of this expression somewhere
> so we don't have to call it each time.

Will do.

Expand All Messages | Collapse All Messages