Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 41081: Sync with Chromium's fork

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 9 months ago by agl
Modified:
16 years, 8 months ago
Reviewers:
reed
Visibility:
Public.

Description

Sync with Chromium's fork * Add the following font metrics fields: + fAvgCharWidth + fXMin + fXMax + fXHeight * Add \#if 0'ed includes for the Freetype headers for Xcode, scons and other tools which chase headers. * Correctly render 1bpp fonts (mostly Chinese fonts at small sizes)

Patch Set 1 #

Total comments: 6

Patch Set 2 : ... #

Total comments: 4

Patch Set 3 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -16 lines) Patch
M include/core/SkPaint.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 2 7 chunks +85 lines, -16 lines 0 comments Download
M src/ports/SkFontHost_ascender.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
agl
16 years, 9 months ago (2009-04-15 21:34:13 UTC) #1
reed
http://codereview.appspot.com/41081/diff/1/2 File include/core/SkPaint.h (right): http://codereview.appspot.com/41081/diff/1/2#newcode627 Line 627: SkScalar fXMin; //!< The minimum bounding box x ...
16 years, 8 months ago (2009-04-22 14:09:59 UTC) #2
agl
http://codereview.appspot.com/41081/diff/1/2 File include/core/SkPaint.h (right): http://codereview.appspot.com/41081/diff/1/2#newcode627 Line 627: SkScalar fXMin; //!< The minimum bounding box x ...
16 years, 8 months ago (2009-04-22 18:19:11 UTC) #3
reed
I'm fine to keep the paint.h as is. We can explore the rect -vs- max/min ...
16 years, 8 months ago (2009-04-22 20:29:03 UTC) #4
agl
http://codereview.appspot.com/41081/diff/1003/2003 File src/ports/SkFontHost_FreeType.cpp (right): http://codereview.appspot.com/41081/diff/1003/2003#newcode789 Line 789: if (os2 && os2->sxHeight) { On 2009/04/22 20:29:03, ...
16 years, 8 months ago (2009-04-22 21:32:55 UTC) #5
reed
16 years, 8 months ago (2009-04-22 21:36:51 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b