Issue 4108042: Specify feature exports for runtime compilation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4108042: Specify feature exports for runtime compilation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by mhermanto

Modified:
15 years, 1 month ago

Reviewers:
johnfargo

CC:
dev-remailer_shindig.apache.org

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+153 lines, -0 lines)			Patch
features/src/main/javascript/features/core.config/feature.xml	View	1 chunk	+22 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/core.json/feature.xml	View	1 chunk	+10 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/core.log/feature.xml	View	1 chunk	+18 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/core.util.urlparams/feature.xml	View	1 chunk	+6 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/core.util/feature.xml	View	1 chunk	+30 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/dynamic-height.height/feature.xml	View	1 chunk	+6 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/dynamic-height.util/feature.xml	View	1 chunk	+6 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/dynamic-height/feature.xml	View	1 chunk	+3 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/globals/feature.xml	View	1 chunk	+10 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/rpc/feature.xml	View	2 chunks	+42 lines, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

johnfargo

LGTM++ One small change. http://codereview.appspot.com/4108042/diff/1/features/src/main/javascript/features/rpc/feature.xml File features/src/main/javascript/features/rpc/feature.xml (right): http://codereview.appspot.com/4108042/diff/1/features/src/main/javascript/features/rpc/feature.xml#newcode62 features/src/main/javascript/features/rpc/feature.xml:62: <exports type="js">gadgets.rpc.init</exports> init() is only ...

15 years, 1 month ago (2011-01-25 21:57:43 UTC) #2

mhermanto

15 years, 1 month ago (2011-01-25 22:14:41 UTC) #3

On Tue, Jan 25, 2011 at 1:57 PM, <johnfargo@gmail.com> wrote:

> LGTM++
>
> One small change.
>
>
Done, exports removed.

>
>
>
http://codereview.appspot.com/4108042/diff/1/features/src/main/javascript/fea...
> File features/src/main/javascript/features/rpc/feature.xml (right):
>
>
>
http://codereview.appspot.com/4108042/diff/1/features/src/main/javascript/fea...
> features/src/main/javascript/features/rpc/feature.xml:62: <exports
> type="js">gadgets.rpc.init</exports>
> init() is only called by the library itself, and need not be exported.
>
>
>
http://codereview.appspot.com/4108042/diff/1/features/src/main/javascript/fea...
> features/src/main/javascript/features/rpc/feature.xml:91: <exports
> type="js">gadgets.rpc.init</exports>
> same
>
>
> http://codereview.appspot.com/4108042/
>

Expand All Messages | Collapse All Messages