code review 4106044: 8l/6l: pe fixes

8l/6l: pe fixes

- fixed length of amd64 .data pe section
  (don't need to include non-initialised data)

- use correct oh/oh64 variable when updating
  data directory in addexports

- simplify and cleanup

[brainman, 2011-01-28 03:59:55]

Hello vcc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[brainman, 2011-01-28 10:24:56]

Hello vcc (cc: golang-dev@googlegroups.com),

Please take another look.

[vcc, 2011-01-28 16:43:48]

LGTM

[rsc, 2011-01-28 21:04:29]

LGTM

http://codereview.appspot.com/4106044/diff/5001/src/cmd/ld/pe.c
File src/cmd/ld/pe.c (right):

http://codereview.appspot.com/4106044/diff/5001/src/cmd/ld/pe.c#newcode142
src/cmd/ld/pe.c:142: ewrite(cout, &fh, sizeof fh);
This code (and the code it replaces) will fail
if run on a big-endian machine.  Since it's not a
new bug, it's okay to leave in this CL, but please do
add 

// TODO: This code should not assume that the
// memory representation is little-endian or
// that the structs are packed identically to
// their file representation.

[brainman, 2011-01-29 12:13:23]

Thank you for review.

http://codereview.appspot.com/4106044/diff/5001/src/cmd/ld/pe.c
File src/cmd/ld/pe.c (right):

http://codereview.appspot.com/4106044/diff/5001/src/cmd/ld/pe.c#newcode142
src/cmd/ld/pe.c:142: ewrite(cout, &fh, sizeof fh);
On 2011/01/28 21:04:35, rsc wrote:
> This code (and the code it replaces) will fail
> if run on a big-endian machine.  ...

There are a few of those in this file. I have put comment for now.

[brainman, 2011-01-29 12:13:48]

*** Submitted as http://code.google.com/p/go/source/detail?r=2f3b95e9a84b ***

8l/6l: pe fixes

- fixed length of amd64 .data pe section
  (don't need to include non-initialised data)

- use correct oh/oh64 variable when updating
  data directory in addexports

- simplify and cleanup

R=vcc, rsc
CC=golang-dev
http://codereview.appspot.com/4106044