code review 4105054: Codelab: correct function definitions for handlers befo...

Codelab: correct function definitions for handlers before closures are introduced.

A couple of post-closure function definitions were introduced too early, making the resulting
code fail compilation.

Also, the TitleValidator regexp was missing.

[aam, 2011-02-06 17:50:05]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[aam, 2011-02-06 21:15:59]

Hello adg (cc: golang-dev@googlegroups.com),

Please take another look.

[aam, 2011-02-06 21:31:18]

Hello adg (cc: golang-dev@googlegroups.com),

Please take another look.

[aam, 2011-02-06 21:32:08]

oops, i just realized that the whole thing is autogenerated, so i
fixed the template instead, but since index.html is also held in the
repository it was changed too.

[adg, 2011-02-07 08:23:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=76543d680825 ***

Codelab: correct function definitions for handlers before closures are
introduced.

A couple of post-closure function definitions were introduced too early, making
the resulting
code fail compilation.

Also, the TitleValidator regexp was missing.

R=adg
CC=golang-dev
http://codereview.appspot.com/4105054

Committer: Andrew Gerrand <adg@golang.org>

[adg, 2011-02-07 08:23:45]

LGTM

Thanks!

On 6 February 2011 18:50,  <mirtchovski@gmail.com> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> Codelab: correct function definitions for handlers before closures are
> introduced.
>
> A couple of post-closure function definitions were introduced too early,
> making the resulting
> code fail compilation.
>
> Please review this at http://codereview.appspot.com/4105054/
>
> Affected files:
>  M doc/codelab/wiki/index.html
>
>
> Index: doc/codelab/wiki/index.html
> ===================================================================
> --- a/doc/codelab/wiki/index.html
> +++ b/doc/codelab/wiki/index.html
> @@ -573,7 +573,7 @@
>  </p>
>
>  <pre>
> -func viewHandler(w http.ResponseWriter, r *http.Request, title string) {
> +func viewHandler(w http.ResponseWriter, r *http.Request) {
>        p, err := loadPage(title)
>        if err != nil {
>                http.Redirect(w, r, &#34;/edit/&#34;+title, http.StatusFound)
> @@ -658,7 +658,7 @@
>  </p>
>
>  <pre>
> -func saveHandler(w http.ResponseWriter, r *http.Request, title string) {
> +func saveHandler(w http.ResponseWriter, r *http.Request) {
>        body := r.FormValue(&#34;body&#34;)
>        p := &amp;Page{Title: title, Body: []byte(body)}
>        err := p.save()
>
>
>