Issue 41043: Add simu_writev, simu_fcntl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 41043: Add simu_writev, simu_fcntl

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by Hajime Tazaki

Modified:
14 years, 5 months ago

Reviewers:
Mathieu Lacage

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -22 lines)			Patch
	M	src/process-manager/simu-fd.cc	View		5 chunks	+120 lines, -22 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Mathieu Lacage

14 years, 5 months ago (2009-04-15 07:16:51 UTC) #2

http://codereview.appspot.com/41043/diff/1/2
File src/process-manager/simu-fd.cc (right):

http://codereview.appspot.com/41043/diff/1/2#newcode423
Line 423: for (int i = 0; i < iovcnt; ++i)
coding style:
for ()
  {
    // stuff
  }

Expand All Messages | Collapse All Messages