Issue 4102044: code review 4102044: misc/vim/syntax: set large value to 'syntax sync'.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4102044: code review 4102044: misc/vim/syntax: set large value to 'syntax sync'. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by mattn

Modified:
14 years, 1 month ago

Reviewers:
niemeyer

CC:
golang-dev, dsymonds, adg

Visibility:
Public.

Description

misc/vim/syntax: set large value to 'syntax sync'.

Patch Set 1 #

Patch Set 2 : code review 4102044: misc/vim/syntax: set large value to 'syntax sync'. #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	misc/vim/syntax/go.vim	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mattn

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 1 month ago (2011-01-27 08:40:43 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=872ed0c4bddc *** misc/vim/syntax: set large value to 'syntax sync'. R=golang-dev, dsymonds, adg ...

14 years, 1 month ago (2011-01-27 13:04:00 UTC) #3

niemeyer

14 years, 1 month ago (2011-01-27 13:15:04 UTC) #4

I've actually been looking at exactly this problem. There's
a faster and more precise way to synchronize Go files using
matching logic, but unfortunately I've hit a Vim bug while
using it.

I have already fixed the bug, and am discussing the fix with
Bram at the moment.  Once that goes into Vim, I'll propose a
CL to change the default syncing.

Expand All Messages | Collapse All Messages