Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(173)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4102042: code review 4102042: net: fix build on old Linux kernels (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by rsc
Modified:
14 years, 1 month ago
Reviewers:
bradfitz
CC:
brad_danga_com, golang-dev
Visibility:
Public.

Description

net: fix build on old Linux kernels Thanks to Mike Beller for identifying the problem. Fixes issue 1442.

Patch Set 1 #

Patch Set 2 : code review 4102042: net: fix build on old Linux kernels #

Patch Set 3 : code review 4102042: net: fix build on old Linux kernels #

Patch Set 4 : code review 4102042: net: fix build on old Linux kernels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/pkg/net/server_test.go View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 1 month ago (2011-01-26 20:32:23 UTC) #1
bradfitz
I confirmed this fixes the problem on Linux 2.6.11.12-xenU
14 years, 1 month ago (2011-01-26 20:43:25 UTC) #2
bradfitz
I confirmed this fixes the problem on Linux 2.6.11.12-xenU
14 years, 1 month ago (2011-01-26 20:43:35 UTC) #3
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=d28049f74374 *** net: fix build on old Linux kernels Thanks to Mike ...
14 years, 1 month ago (2011-01-26 20:46:19 UTC) #4
bradfitz
14 years, 1 month ago (2011-01-26 20:46:27 UTC) #5 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b