Issue 4099042: code review 4099042: codereview: handle file patterns better

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4099042: code review 4099042: codereview: handle file patterns better (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by rsc

Modified:
14 years, 1 month ago

Reviewers:

CC:
adg, niemeyer, bradfitz, golang-dev

Visibility:
Public.

Description

codereview: handle file patterns better If a file pattern is given and matches files that look like they need to be hg added or hg removed, offer to do so. If a file pattern is given and matches files in another CL, warn. If a file pattern doesn't match anything, point that out. Vet first line of CL description. Fixes issue 972.

Patch Set 1 #

Patch Set 2 : code review 4099042: codereview: handle file patterns better #

Patch Set 3 : code review 4099042: codereview: handle file patterns better #

Total comments: 5

Patch Set 4 : code review 4099042: codereview: handle file patterns better #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -19 lines)			Patch
	M	.hgignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	lib/codereview/codereview.py	View	1 2 3	11 chunks	+137 lines, -19 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: bradfitzgo, golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 1 month ago (2011-01-21 18:29:15 UTC) #1

niemeyer

Don't know much about hg/codereview internals, so just a quick overview. http://codereview.appspot.com/4099042/diff/6001/lib/codereview/codereview.py File lib/codereview/codereview.py (right): ...

14 years, 1 month ago (2011-01-22 02:20:03 UTC) #2

adg

LGTM http://codereview.appspot.com/4099042/diff/6001/lib/codereview/codereview.py File lib/codereview/codereview.py (right): http://codereview.appspot.com/4099042/diff/6001/lib/codereview/codereview.py#newcode742 lib/codereview/codereview.py:742: desc_re = '^(.*: |tag release\.|release\.|fix build)' s/\*/+/ http://codereview.appspot.com/4099042/diff/6001/lib/codereview/codereview.py#newcode2398 ...

14 years, 1 month ago (2011-01-23 22:49:37 UTC) #3

rsc

14 years, 1 month ago (2011-01-24 19:14:28 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=0357ebc995ce ***

codereview: handle file patterns better

If a file pattern is given and matches files that look
like they need to be hg added or hg removed, offer to do so.

If a file pattern is given and matches files in another CL, warn.

If a file pattern doesn't match anything, point that out.

Vet first line of CL description.

Fixes issue 972.

R=adg, niemeyer
CC=bradfitzgo, golang-dev
http://codereview.appspot.com/4099042

Expand All Messages | Collapse All Messages