Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(966)

Issue 4092048: code review 4092048: runtime: fix asm.h on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by rsc
Modified:
14 years, 1 month ago
Reviewers:
CC:
adg, brainman, golang-dev
Visibility:
Public.

Description

runtime: fix asm.h on Windows Thanks to mhantsch@gmail.com.

Patch Set 1 #

Patch Set 2 : diff -r 75d6775388d8 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/runtime/mkasmh.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
14 years, 1 month ago (2011-02-03 19:18:27 UTC) #1
adg
LGTM On 4 February 2011 06:18, <rsc@golang.org> wrote: > Reviewers: adg, > > Message: > ...
14 years, 1 month ago (2011-02-04 06:50:23 UTC) #2
brainman
LGTM
14 years, 1 month ago (2011-02-04 08:02:33 UTC) #3
rsc
14 years, 1 month ago (2011-02-04 19:33:03 UTC) #4
*** Submitted as e0a328518c30 ***

runtime: fix asm.h on Windows

Thanks to mhantsch@gmail.com.

R=adg, brainman
CC=golang-dev
http://codereview.appspot.com/4092048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b