Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(912)

Issue 4092044: Enum for different types of JS compilation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by mhermanto
Modified:
15 years, 1 month ago
Reviewers:
johnfargo, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

This will extend debug=0|1.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java View 1 chunk +45 lines, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/JsCompileModeTest.java View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3
mhermanto
15 years, 1 month ago (2011-01-31 22:21:59 UTC) #1
johnfargo
LGTM I assume this will be pulled into serving code next.
15 years, 1 month ago (2011-01-31 23:08:04 UTC) #2
mhermanto
15 years, 1 month ago (2011-01-31 23:09:46 UTC) #3
Yes.

On Mon, Jan 31, 2011 at 3:08 PM, <johnfargo@gmail.com> wrote:

> LGTM
>
> I assume this will be pulled into serving code next.
>
>
> http://codereview.appspot.com/4092044/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b