Issue 4085041: Allow overriding gadget url schema

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4085041: Allow overriding gadget url schema

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by zhoresh

Modified:
15 years, 1 month ago

Reviewers:
johnfargo, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

In order to support extra gadgets storage we need to allow special schema for gadget url. The change seperate the url schema check so it can be easily override.

Patch Set 1 #

Total comments: 1

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java	View		3 chunks	+10 lines, -6 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnfargo

http://codereview.appspot.com/4085041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java (right): http://codereview.appspot.com/4085041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java#newcode68 java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java:68: protected void validateGadgetUrlSchema(Uri url) throws ProcessingException { nit: I'd ...

15 years, 1 month ago (2011-01-20 01:20:24 UTC) #2

johnfargo

LGTM otherwise. On Wed, Jan 19, 2011 at 5:20 PM, <johnfargo@gmail.com> wrote: > > > ...

15 years, 1 month ago (2011-01-20 01:20:37 UTC) #3

zhoresh

15 years, 1 month ago (2011-01-20 03:32:15 UTC) #4

On Wed, Jan 19, 2011 at 5:20 PM, <johnfargo@gmail.com> wrote:

>
>
>
http://codereview.appspot.com/4085041/diff/1/java/gadgets/src/main/java/org/a...
> File
>
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
> (right):
>
>
>
http://codereview.appspot.com/4085041/diff/1/java/gadgets/src/main/java/org/a...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java:68:
>
> protected void validateGadgetUrlSchema(Uri url) throws
> ProcessingException {
> nit: I'd just call this validateGadgetUri


Renamed and committed. Thanks!


>
>
> http://codereview.appspot.com/4085041/
>

Expand All Messages | Collapse All Messages