code review 4084044: gob: updates to the debugging tool.

gob: updates to the debugging tool.
- complex numbers now supported.
- entirely independent of standard decode code.
- parser has no read-ahead; that is, the scanning works
simply by reading the values as they arrive, not by trying
to count bytes for message boundaries, a proof of concept
for the pending rewrite of the regular decoder.

[r, 2011-01-25 18:47:21]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2011-01-26 02:52:10]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-01-28 18:01:50]

LGTM

http://codereview.appspot.com/4084044/diff/1/src/pkg/gob/debug.go
File src/pkg/gob/debug.go (right):

http://codereview.appspot.com/4084044/diff/1/src/pkg/gob/debug.go#newcode103
src/pkg/gob/debug.go:103: remain         int  // the number of bytes known to
remain in the input
s/known/expected/

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go#newcode172
src/pkg/gob/debug.go:172: func (deb *debugger) consume(n int) {
s/consume/&d/

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go#newcode178
src/pkg/gob/debug.go:178: // readInt returns the next int, which must be
present,
you have 

readInt() int64
readUint() uint64
getInt() int
getUint() uint
getTypeId() typeId
getString() string
getDelta(int) int

i suggest dropping the verbs:

int64() int64
uint64() uint64
int() int
uint() uint
typeId() typeId
string() string
delta(int) int

also the use of getInt is not uniform.
search for int(deb

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go#newcode179
src/pkg/gob/debug.go:179: // and the number of bytes it consumed.
d

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go#newcode186
src/pkg/gob/debug.go:186: // and the number of bytes it consumed.
d

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go#newcode470
src/pkg/gob/debug.go:470: id := typeId(deb.readInt())
deb.typeId()

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go#newcode573
src/pkg/gob/debug.go:573: x := int(deb.readUint())
can use deb.int() here

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go#newcode579
src/pkg/gob/debug.go:579: x := int(deb.readUint())
can use deb.int() here

[r2, 2011-01-28 18:44:09]

will change the names, but note that int(uint()) is not the same as int().  one
does a direct bit conversion, the other is a computation.  or: one takes an
unsigned integer and uses it as a regular int, the other decodes a singed
integer from the encoded data stream.

-rob

[r, 2011-01-28 18:52:38]

submitting

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go
File src/pkg/gob/debug.go (right):

http://codereview.appspot.com/4084044/diff/2001/src/pkg/gob/debug.go#newcode103
src/pkg/gob/debug.go:103: remain         int  // the number of bytes known to
remain in the input
actually, it's known: it's the length of the buffer. the expectation is compared
with this reality.

[r, 2011-01-28 18:53:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=ce7d0f2b9e03 ***

gob: updates to the debugging tool.
- complex numbers now supported.
- entirely independent of standard decode code.
- parser has no read-ahead; that is, the scanning works
simply by reading the values as they arrive, not by trying
to count bytes for message boundaries, a proof of concept
for the pending rewrite of the regular decoder.

R=rsc, r2
CC=golang-dev
http://codereview.appspot.com/4084044