code review 4080050: 8l: prevent SEGFAULT when 8l invoked with GOOS=plan9 an...

8l: prevent SEGFAULT when 8l invoked with GOOS=plan9 and -s is not passed. 

Add symbols and line numbers to Plan 9 a.out.

[paulzhol, 2011-02-02 15:37:42]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-02-03 03:57:50]

looks pretty good.
please revert the changes to
HEADTYPE 0 and 1.
they are probably unused but even so
it seems odd to change them.

http://codereview.appspot.com/4080050/diff/1006/src/cmd/8l/asm.c
File src/cmd/8l/asm.c (right):

http://codereview.appspot.com/4080050/diff/1006/src/cmd/8l/asm.c#newcode798
src/cmd/8l/asm.c:798: lputb(0x160L<<16);		/* magic and sections */
Why did these change?

http://codereview.appspot.com/4080050/diff/1006/src/cmd/8l/asm.c#newcode835
src/cmd/8l/asm.c:835: lputb(entryvalue());		/* va of entry */
Why did this change?

http://codereview.appspot.com/4080050/diff/1006/src/cmd/ld/symtab.c
File src/cmd/ld/symtab.c (right):

http://codereview.appspot.com/4080050/diff/1006/src/cmd/ld/symtab.c#newcode140
src/cmd/ld/symtab.c:140: putp9aoutsym(Sym *x, char *s, int t, vlong addr, vlong
size, int ver, Sym *go)
putplan9sym is fine

http://codereview.appspot.com/4080050/diff/1006/src/cmd/ld/symtab.c#newcode191
src/cmd/ld/symtab.c:191: asmp9aoutsym(void)
s/p9aout/plan9/

[paulzhol, 2011-02-03 08:48:24]

Thanks for the review!

I renamed 8l/asm.c lput() and wput() to lputb() and wputb() respectively, so
they will match the naming in 6l/asm.c. 
This was necessary because ld/symtab.c is used in both and the changes to
HEADTYPE 0 and 1 were just so 8l would compile.

Pavel

http://codereview.appspot.com/4080050/diff/1006/src/cmd/ld/symtab.c
File src/cmd/ld/symtab.c (right):

http://codereview.appspot.com/4080050/diff/1006/src/cmd/ld/symtab.c#newcode140
src/cmd/ld/symtab.c:140: putp9aoutsym(Sym *x, char *s, int t, vlong addr, vlong
size, int ver, Sym *go)
On 2011/02/03 03:57:51, rsc wrote:
> putplan9sym is fine

Done.

http://codereview.appspot.com/4080050/diff/1006/src/cmd/ld/symtab.c#newcode191
src/cmd/ld/symtab.c:191: asmp9aoutsym(void)
On 2011/02/03 03:57:51, rsc wrote:
> s/p9aout/plan9/

Done.

[rsc, 2011-02-03 19:34:35]

LGTM

[rsc, 2011-02-04 19:33:23]

*** Submitted as 8e19d9fd1e6f ***

8l: fix crash writing Plan 9 binaries

Was crashing with GOOS=plan9 unless -s was passed.
Add symbols and line numbers to Plan 9 a.out.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4080050

Committer: Russ Cox <rsc@golang.org>