Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 4077052: Implement generated visitor classes in C++.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by kenton
Modified:
3 years, 11 months ago
Reviewers:
chen3feng, jasonh, Jisi Liu
Base URL:
http://protobuf.googlecode.com/svn/trunk/
Visibility:
Public.

Description

See discussion thread: https://groups.google.com/group/protobuf/browse_thread/thread/598efbb11aedfc62

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1490 lines, -232 lines) Patch
M src/google/protobuf/compiler/cpp/cpp_enum_field.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_enum_field.cc View 2 chunks +97 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_field.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_field.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_helpers.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_helpers.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_message.h View 3 chunks +17 lines, -3 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_message.cc View 17 chunks +323 lines, -57 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_message_field.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_message_field.cc View 2 chunks +168 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_primitive_field.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_primitive_field.cc View 2 chunks +83 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_string_field.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_string_field.cc View 2 chunks +70 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/cpp/cpp_unittest.cc View 1 chunk +257 lines, -0 lines 1 comment Download
M src/google/protobuf/compiler/plugin.pb.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/google/protobuf/compiler/plugin.pb.cc View 12 chunks +18 lines, -18 lines 1 comment Download
M src/google/protobuf/descriptor.proto View 1 chunk +7 lines, -0 lines 0 comments Download
M src/google/protobuf/descriptor.pb.h View 24 chunks +53 lines, -1 line 0 comments Download
M src/google/protobuf/descriptor.pb.cc View 91 chunks +192 lines, -152 lines 0 comments Download
M src/google/protobuf/unittest.proto View 5 chunks +27 lines, -0 lines 0 comments Download
M src/google/protobuf/wire_format_lite.h View 3 chunks +22 lines, -0 lines 0 comments Download
M src/google/protobuf/wire_format_lite_inl.h View 4 chunks +88 lines, -1 line 1 comment Download

Messages

Total messages: 3
kenton
Hi Jisi and Jason, I'd like you to do a code review. This is the ...
6 years ago (2011-02-01 19:03:54 UTC) #1
jasonh
What's your plan for extension and unknown field support? The latter seems easier since unknown ...
6 years ago (2011-02-10 19:35:49 UTC) #2
chen3feng
3 years, 11 months ago (2013-03-27 13:12:10 UTC) #3
https://codereview.appspot.com/4077052/diff/1/src/google/protobuf/compiler/pl...
File src/google/protobuf/compiler/plugin.pb.cc (right):

https://codereview.appspot.com/4077052/diff/1/src/google/protobuf/compiler/pl...
src/google/protobuf/compiler/plugin.pb.cc:235: #define DO_(EXPRESSION) if
(!(EXPRESSION)) return false
This alignment breaks google coding style
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted