Issue 4077045: code review 4077045: codelab/wiki: fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4077045: code review 4077045: codelab/wiki: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by rsc

Modified:
14 years, 1 month ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

codelab/wiki: fix build

Patch Set 1 #

Patch Set 2 : code review 4077045: codelab/wiki: fix build #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	doc/codelab/wiki/test.sh	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
	M	doc/codelab/wiki/test_edit.good	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 1 month ago (2011-01-26 17:54:06 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=c53346228201 *** codelab/wiki: fix build TBR=adg CC=golang-dev http://codereview.appspot.com/4077045

14 years, 1 month ago (2011-01-26 17:54:09 UTC) #2

adg

LGTM Thanks for fixing this. Sorry for breaking the build. :-( On 27 January 2011 ...

14 years, 1 month ago (2011-01-26 22:02:03 UTC) #3

rsc

14 years, 1 month ago (2011-01-26 22:12:44 UTC) #4

> Thanks for fixing this. Sorry for breaking the build. :-(

we've all been there

Expand All Messages | Collapse All Messages