Issue 4073043: code review 4073043: runtime/cgo: fix cross-compiling windows packages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4073043: code review 4073043: runtime/cgo: fix cross-compiling windows packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by brainman

Modified:
14 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime/cgo: fix cross-compiling windows packages

Patch Set 1 #

Patch Set 2 : code review 4073043: runtime/cgo: fix cross-compiling windows packages #

Patch Set 3 : code review 4073043: runtime/cgo: fix cross-compiling windows packages #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/pkg/runtime/cgo/Makefile	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 1 month ago (2011-01-27 23:27:21 UTC) #1

brainman

Perhaps someone has better idea. I'm happy to listen. Alex

14 years, 1 month ago (2011-01-27 23:28:28 UTC) #2

rsc

LGTM On Thu, Jan 27, 2011 at 18:28, <alex.brainman@gmail.com> wrote: > Perhaps someone has better ...

14 years, 1 month ago (2011-01-28 14:44:18 UTC) #3

brainman

14 years, 1 month ago (2011-01-29 11:57:27 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=893697059dc0 ***

runtime/cgo: fix cross-compiling windows packages

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4073043

Expand All Messages | Collapse All Messages