Issue 40690050: Implement ssh import key command

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 40690050: Implement ssh import key command (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by wallyworld

Modified:
10 years, 5 months ago

Reviewers:
mp+198875, axw

Visibility:
Public.

Description

Implement ssh import key command This branch follows on from the previous work to provide add/delete/list commands for ssh keys. The import command uses ssh-import-id to allow a Launchpad or GitHub or .... ssh key to be imported into Juju. https://code.launchpad.net/~wallyworld/juju-core/import-ssh-keys/+merge/198875 Requires: https://code.launchpad.net/~wallyworld/juju-core/authorised-keys-add-delete/+merge/198849 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Implement ssh import key command #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+357 lines, -75 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/authorisedkeys.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	cmd/juju/authorisedkeys_add.go	View	1	2 chunks	+24 lines, -21 lines	0 comments	Download
M	cmd/juju/authorisedkeys_delete.go	View	1	2 chunks	+25 lines, -22 lines	0 comments	Download
A	cmd/juju/authorisedkeys_import.go	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download
M	cmd/juju/authorisedkeys_test.go	View	1	6 chunks	+51 lines, -29 lines	0 comments	Download
M	state/api/keymanager/client.go	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	state/api/keymanager/client_test.go	View		3 chunks	+25 lines, -0 lines	0 comments	Download
M	state/apiserver/keymanager/keymanager.go	View		3 chunks	+85 lines, -1 line	0 comments	Download
M	state/apiserver/keymanager/keymanager_test.go	View		2 chunks	+43 lines, -0 lines	0 comments	Download
A	state/apiserver/keymanager/testing/fakesshimport.go	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

LGTM https://codereview.appspot.com/40690050/diff/1/cmd/juju/authorisedkeys_import.go File cmd/juju/authorisedkeys_import.go (right): https://codereview.appspot.com/40690050/diff/1/cmd/juju/authorisedkeys_import.go#newcode16 cmd/juju/authorisedkeys_import.go:16: Import a new authorised ssh key to allow ...

10 years, 5 months ago (2013-12-13 06:14:44 UTC) #2

wallyworld

10 years, 5 months ago (2013-12-13 06:54:10 UTC) #3

Please take a look.

https://codereview.appspot.com/40690050/diff/1/cmd/juju/authorisedkeys_import.go
File cmd/juju/authorisedkeys_import.go (right):

https://codereview.appspot.com/40690050/diff/1/cmd/juju/authorisedkeys_import...
cmd/juju/authorisedkeys_import.go:16: Import a new authorised ssh key to allow
the holder of that key to log on to Juju nodes or machines.
On 2013/12/13 06:14:45, axw wrote:
> Inconsistent use of authorised/authorized
> I guess this should be z, since it's user-facing

Weeeell, it's still an authorised key. Just so happens to be stored in a file
that is misspelt for 90%+ of the English speaking world. And all the other
commands use authorised. So if we change it, I'd like to do it in anaother
branch.

https://codereview.appspot.com/40690050/diff/1/cmd/juju/authorisedkeys_import...
cmd/juju/authorisedkeys_import.go:44: return cmd.CheckEmpty(args[1:])
On 2013/12/13 06:14:45, axw wrote:
> Why only support one when the API supports multiple?

Done.

Expand All Messages | Collapse All Messages