Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 4061045: code review 4061045: fmt/doc: define width and precision for strings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by r
Modified:
14 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

fmt/doc: define width and precision for strings.

Patch Set 1 #

Patch Set 2 : code review 4061045: fmt/doc: define width and precision for strings. #

Patch Set 3 : code review 4061045: fmt/doc: define width and precision for strings. #

Patch Set 4 : code review 4061045: fmt/doc: define width and precision for strings. #

Total comments: 1

Patch Set 5 : code review 4061045: fmt/doc: define width and precision for strings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/pkg/fmt/doc.go View 1 2 3 4 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 5
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 1 month ago (2011-01-26 18:55:27 UTC) #1
r
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 1 month ago (2011-01-26 18:57:14 UTC) #2
r
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 1 month ago (2011-01-26 18:58:06 UTC) #3
rsc
LGTM http://codereview.appspot.com/4061045/diff/1002/src/pkg/fmt/doc.go File src/pkg/fmt/doc.go (right): http://codereview.appspot.com/4061045/diff/1002/src/pkg/fmt/doc.go#newcode47 src/pkg/fmt/doc.go:47: For numeric values, the width and precision flags ...
14 years, 1 month ago (2011-01-26 19:00:52 UTC) #4
r
14 years, 1 month ago (2011-01-26 19:10:45 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=37fd41938777 ***

fmt/doc: define width and precision for strings.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4061045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b