code review 40600043: cmd/nm: reimplement in Go

src/cmd/go/pkg.go

 // Copyright 2011 The Go Authors.  All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package main
 
 import (
         "bytes"
         "errors"
         "fmt"
@@ skipping 289 matching lines @@
         toRoot targetDir = iota // to bin dir inside package root (default)
         toTool                  // GOROOT/pkg/tool
         toBin                   // GOROOT/bin
 )
 
 // goTools is a map of Go program import path to install target directory.
 var goTools = map[string]targetDir{
         "cmd/api":                              toTool,
         "cmd/cgo":                              toTool,
         "cmd/fix":                              toTool,
+        "cmd/nm":                               toTool,
         "cmd/yacc":                             toTool,
         "code.google.com/p/go.tools/cmd/cover": toTool,
         "code.google.com/p/go.tools/cmd/godoc": toBin,
         "code.google.com/p/go.tools/cmd/vet":   toTool,
 }
 
 // expandScanner expands a scanner.List error into all the errors in the list.
 // The default Error method only shows the first error.
 func expandScanner(err error) error {
         // Look for parser errors.
@@ skipping 531 matching lines @@
         root = filepath.Clean(root)
         if !strings.HasSuffix(root, sep) {
                 root += sep
         }
         dir = filepath.Clean(dir)
         if !strings.HasPrefix(dir, root) {
                 return "", false
         }
         return filepath.ToSlash(dir[len(root):]), true
 }