code review 4058046: windows: multiple improvements and cleanups

src/pkg/runtime/windows/mem.c

 // Copyright 2010 The Go Authors.  All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 #include "runtime.h"
 #include "os.h"
 #include "defs.h"
 #include "malloc.h"
 
 enum {
         MEM_COMMIT = 0x1000,
         MEM_RESERVE = 0x2000,
         MEM_RELEASE = 0x8000,
 ········
         PAGE_EXECUTE_READWRITE = 0x40,
 };
-
-static void
-abort(int8 *name)
-{
-        uintptr errno;
-
-        errno = runtime·getlasterror();
-        runtime·printf("%s failed with errno=%d\n", name, errno);
-        runtime·throw(name);
-}
 
 #pragma dynimport runtime·VirtualAlloc VirtualAlloc "kernel32.dll"
 #pragma dynimport runtime·VirtualFree VirtualFree "kernel32.dll"
 extern void *runtime·VirtualAlloc;
 extern void *runtime·VirtualFree;
 
 void*
 runtime·SysAlloc(uintptr n)
 {
         mstats.sys += n;
         return runtime·stdcall(runtime·VirtualAlloc, 4, nil, n, MEM_COMMIT | MEM_RESERVE, PAGE_EXECUTE_READWRITE);
 }
 
 void
 runtime·SysUnused(void *v, uintptr n)
 {
         USED(v);
         USED(n);
 }
 
 void
 runtime·SysFree(void *v, uintptr n)
 {
         uintptr r;
 
         mstats.sys -= n;
         r = (uintptr)runtime·stdcall(runtime·VirtualFree, 3, v, 0, MEM_RELEASE);
         if(r == 0)
-                abort("VirtualFree");
+                runtime·throw("runtime: failed to release pages");
 }
 
 void*
 runtime·SysReserve(void *v, uintptr n)
 {
         return runtime·stdcall(runtime·VirtualAlloc, 4, v, n, MEM_RESERVE, 0);
 }
 
 void
 runtime·SysMap(void *v, uintptr n)
 {
         void *p;
 ········
         mstats.sys += n;
         p = runtime·stdcall(runtime·VirtualAlloc, 4, v, n, MEM_COMMIT, PAGE_EXECUTE_READWRITE);
         if(p != v)
                 runtime·throw("runtime: cannot map pages in arena address space");
 }