Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 40570044: Add basic support for touch events. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by kpreid2
Modified:
12 years, 2 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Whitelist touch event types (touchstart, etc.) * Tame event properties touches, targetTouches, changedTouches. * Tamings for Touch and TouchList types. Supporting changes: * PT.TameMemoIf now uses the property name from the environment (refactoring only). * Removed stray whitespace in domado.js. Note that there are unfortunately no tests added since the existing test automation only does click events (not touches) and there does not appear to be a portable way to create touch events or other touch-related data types from within the browser, even. @r5644, r5645

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -27 lines) Patch
M src/com/google/caja/lang/html/htmlext-attributes.json View 1 chunk +13 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/domado.js View 23 chunks +113 lines, -25 lines 1 comment Download
M tests/com/google/caja/plugin/test-domado-events-guest.html View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/test-scan-guest.js View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 2
kpreid2
12 years, 2 months ago (2013-12-10 22:46:07 UTC) #1
felix8a
12 years, 2 months ago (2013-12-10 23:41:54 UTC) #2
lgtm modulo typo

I'm ok with the flimsy testing, but it might be nice to have a manual demo app
somewhere, which would probably have caught the typo.

https://codereview.appspot.com/40570044/diff/1/src/com/google/caja/plugin/dom...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/40570044/diff/1/src/com/google/caja/plugin/dom...
src/com/google/caja/plugin/domado.js:5935: this.target =
tameRelatedNode(feral.taeget);
typo "taeget"
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b