Issue 4047049: Replacement of hard coded field exclusion list in account_invoice

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4047049: Replacement of hard coded field exclusion list in account_invoice (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by roba

Modified:
14 years, 3 months ago

Reviewers:
yangoon, udono

Visibility:
Public.

Patch Set 2 : Replacement of hard coded field exclusion list in account_invoice #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	invoice.py	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/4047049/diff/1/invoice.py File invoice.py (right): http://codereview.appspot.com/4047049/diff/1/invoice.py#newcode122 invoice.py:122: self._field_check_exclude = ['state', 'payment_lines', I will rename the attribute: ...

15 years ago (2011-01-30 10:58:00 UTC) #1

ced

LGTM PS: don't forget the option --send_mail of upload.py when you upload a new version ...

15 years ago (2011-01-31 15:22:13 UTC) #2

ced

You can submit now the patch on roundup following http://code.google.com/p/tryton/wiki/HowtoContribute

15 years ago (2011-02-03 00:08:35 UTC) #5

Can be closed

Expand All Messages | Collapse All Messages