Issue 4042045: code review 4042045: 6l: Add comment relative to CMOV* relocation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4042045: code review 4042045: 6l: Add comment relative to CMOV* relocation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by niemeyer

Modified:
14 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

6l: Add comment relative to CMOV* relocation My apologies. I've changed the comment as requested but forgot to upload. Here it is. I've also noted the fact that the symbol just needs relocation, but it doesn't have to be in .dynsym.

Patch Set 1 #

Patch Set 2 : code review 4042045: 6l: Add comment relative to CMOV* relocation #

Patch Set 3 : code review 4042045: 6l: Add comment relative to CMOV* relocation #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/cmd/6l/asm.c	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 1 month ago (2011-01-28 06:35:39 UTC) #1

rsc

14 years, 1 month ago (2011-02-01 16:49:35 UTC) #3

*** Submitted as 12a5026ad4fd ***

6l: add comment to CMOV* relocation

R=rsc
CC=golang-dev
http://codereview.appspot.com/4042045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages