Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 40370044: tweak for domado-special viewport-dependent tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by felix8a
Modified:
12 years, 2 months ago
Reviewers:
kpreid2, kpreid_google
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

domado-special has a few tests that rely on the guest content being larger than the guest viewport, and deleting the history-sniff tests made the content sometimes smaller than the viewport. So this change reduces the viewport size. This fixes https://code.google.com/p/google-caja/issues/detail?id=1874

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tests/com/google/caja/plugin/test-domado-special-guest.html View 1 chunk +6 lines, -6 lines 3 comments Download
M tests/com/google/caja/plugin/test-domado-special-initial-state.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
felix8a
12 years, 2 months ago (2013-12-11 00:19:04 UTC) #1
kpreid2
https://codereview.appspot.com/40370044/diff/1/tests/com/google/caja/plugin/test-domado-special-guest.html File tests/com/google/caja/plugin/test-domado-special-guest.html (right): https://codereview.appspot.com/40370044/diff/1/tests/com/google/caja/plugin/test-domado-special-guest.html#newcode305 tests/com/google/caja/plugin/test-domado-special-guest.html:305: <p>testResizing and testScrolling need a little extra content to ...
12 years, 2 months ago (2013-12-11 00:54:33 UTC) #2
felix8a
https://codereview.appspot.com/40370044/diff/1/tests/com/google/caja/plugin/test-domado-special-guest.html File tests/com/google/caja/plugin/test-domado-special-guest.html (right): https://codereview.appspot.com/40370044/diff/1/tests/com/google/caja/plugin/test-domado-special-guest.html#newcode305 tests/com/google/caja/plugin/test-domado-special-guest.html:305: <p>testResizing and testScrolling need a little extra content to ...
12 years, 2 months ago (2013-12-11 01:12:37 UTC) #3
kpreid2
https://codereview.appspot.com/40370044/diff/1/tests/com/google/caja/plugin/test-domado-special-guest.html File tests/com/google/caja/plugin/test-domado-special-guest.html (right): https://codereview.appspot.com/40370044/diff/1/tests/com/google/caja/plugin/test-domado-special-guest.html#newcode305 tests/com/google/caja/plugin/test-domado-special-guest.html:305: <p>testResizing and testScrolling need a little extra content to ...
12 years, 2 months ago (2013-12-11 01:58:13 UTC) #4
felix8a
On 2013/12/11 01:58:13, kpreid2 wrote: > https://codereview.appspot.com/40370044/diff/1/tests/com/google/caja/plugin/test-domado-special-guest.html > File tests/com/google/caja/plugin/test-domado-special-guest.html (right): > > https://codereview.appspot.com/40370044/diff/1/tests/com/google/caja/plugin/test-domado-special-guest.html#newcode305 > ...
12 years, 2 months ago (2014-01-07 20:42:59 UTC) #5
kpreid_google
On 2014/01/07 20:42:59, felix8a wrote: > Sorry, this fell out of my inbox. Is this ...
12 years, 2 months ago (2014-01-07 21:19:30 UTC) #6
felix8a
On 2014/01/07 21:19:30, kpreid_google wrote: > On 2014/01/07 20:42:59, felix8a wrote: > > Sorry, this ...
12 years, 2 months ago (2014-01-07 21:24:59 UTC) #7
kpreid2
On 2014/01/07 21:24:59, felix8a wrote: > On 2014/01/07 21:19:30, kpreid_google wrote: > > It's not ...
12 years, 2 months ago (2014-01-07 21:32:33 UTC) #8
felix8a
On 2014/01/07 21:32:33, kpreid2 wrote: > I think the conclusion here is that we really ...
12 years, 2 months ago (2014-01-07 22:09:04 UTC) #9
felix8a
12 years, 2 months ago (2014-01-07 22:37:04 UTC) #10
@r5655 trunk
@r5656 branches/es53
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b