Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(426)

Issue 4029047: code review 4029047: misc/vim: Document better syntax sync parameter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by niemeyer
Modified:
14 years, 1 month ago
Reviewers:
CC:
adg, dsymonds, golang-dev
Visibility:
Public.

Description

misc/vim: Document better syntax sync parameter Forcing the synchronization of 500 lines is both slower and less precise than searching for a known sync point. Unfortunately, though, the way to synchronize correctly is using the grouphere instruction, which has a bug. I've already proposed the fix to Vim, so future releases should have this working. We can continue using the 500 lines syncing for now. This change just documents the proper way to sync.

Patch Set 1 #

Patch Set 2 : code review 4029047: misc/vim: Document better syntax sync parameter #

Patch Set 3 : code review 4029047: misc/vim: Document better syntax sync parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M misc/vim/syntax/go.vim View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
niemeyer
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 1 month ago (2011-01-27 23:15:23 UTC) #1
dsymonds
What about ^package and ^import?
14 years, 1 month ago (2011-01-27 23:31:43 UTC) #2
niemeyer
> What about ^package and ^import? Both of these are necessarily at the start of ...
14 years, 1 month ago (2011-01-27 23:38:41 UTC) #3
adg
LGTM
14 years, 1 month ago (2011-02-01 00:11:08 UTC) #4
adg
14 years, 1 month ago (2011-02-01 00:12:52 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=7b6f4749ccbb ***

misc/vim: Document better syntax sync parameter

Forcing the synchronization of 500 lines is both slower and
less precise than searching for a known sync point.
Unfortunately, though, the way to synchronize correctly is
using the grouphere instruction, which has a bug.

I've already proposed the fix to Vim, so future releases
should have this working.  We can continue using the 500 lines
syncing for now.

This change just documents the proper way to sync.

R=adg, dsymonds
CC=golang-dev
http://codereview.appspot.com/4029047

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b