Issue 4023060: code review 4023060: cgo: allow use of C.f

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4023060: code review 4023060: cgo: allow use of C.f (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by rsc

Modified:
14 years, 2 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

cgo: rename internal f to avoid conflict with possible C global named f Fixes issue 1452.

Patch Set 1 #

Patch Set 2 : diff -r c45c540f43cb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 26ff781f396e https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/cgo/gcc.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-02-02 23:06:31 UTC) #1

LGTM but please change CL description to cgo: rename internal 'f' to avoid colliding with ...

14 years, 2 months ago (2011-02-02 23:44:13 UTC) #2

rsc

14 years, 2 months ago (2011-02-02 23:53:05 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e5af7083456c ***

cgo: rename internal f to avoid conflict with possible C global named f

Fixes issue 1452.

R=r
CC=golang-dev
http://codereview.appspot.com/4023060

Expand All Messages | Collapse All Messages