Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(280)

Issue 40122: Update dashed slurs to have variable thickness. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by Carl
Modified:
8 years, 5 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Update dashed slurs to have variable thickness. Dashed slurs are now written as bezier sandwiches, like regular slurs. Moved dash-period and dash-fraction from properties for slurs, phrasingSlurs, and ties. Created new property dash-definition that contains a list of dash-descriptions for each segment of the slur. Defined new ommands \slurHalfDashed and \slurHalfSolid. Changed bezier-sandwich interface to include thickness parameter that is used for slurs. This required changes to vaticana=ligature. Added extract and split to Bezier class. Adjusted header files to reflect new calling lists. arpeggio.cc is changed because there is a slur-arpeggio type. Adjusted documentation to reflect changes.

Patch Set 1 #

Patch Set 2 : Latest proposal for improved tablature #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -18 lines) Patch
A input/regression/dead-notes.ly View 1 chunk +26 lines, -0 lines 0 comments Download
A input/regression/modern-tab-clef.ly View 1 chunk +16 lines, -0 lines 0 comments Download
A input/regression/palm-mute.ly View 1 chunk +27 lines, -0 lines 0 comments Download
A input/regression/tablature-full-notation.ly View 1 chunk +36 lines, -0 lines 0 comments Download
A input/regression/tablature-glissando.ly View 1 chunk +23 lines, -0 lines 0 comments Download
A input/regression/tablature-grace-notes.ly View 1 chunk +24 lines, -0 lines 0 comments Download
A input/regression/tablature-tie-behaviour.ly View 1 chunk +31 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 3 chunks +38 lines, -2 lines 0 comments Download
M ly/property-init.ly View 1 1 chunk +81 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/music-functions.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +0 lines, -16 lines 0 comments Download
M scm/parser-clef.scm View 1 chunk +7 lines, -0 lines 0 comments Download
A scm/tablature.scm View 1 chunk +178 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b