Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(446)

Issue 40100: Issue tags for the Python bug tracker

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by ajaksu
Modified:
4 years, 10 months ago
Reviewers:
techtonik
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Correct diff #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -5 lines) Patch
A instances/python-dev/detectors/tagsauditor.py View 1 chunk +59 lines, -0 lines 4 comments Download
M instances/python-dev/html/issue.index.html View 1 4 chunks +52 lines, -0 lines 0 comments Download
M instances/python-dev/html/issue.item.html View 2 chunks +27 lines, -0 lines 0 comments Download
M instances/python-dev/html/issue.search.html View 1 chunk +12 lines, -0 lines 0 comments Download
M instances/python-dev/schema.py View 8 chunks +21 lines, -5 lines 1 comment Download

Messages

Total messages: 1
techtonik
4 years, 10 months ago #1
I am not able to test interface itself, so I've just played a bit with this
awesome review tool.

http://codereview.appspot.com/40100/diff/4/1001
File instances/python-dev/detectors/tagsauditor.py (right):

http://codereview.appspot.com/40100/diff/4/1001#newcode6
Line 6: ALLOWED_CHARS = '[a-z_-]+$'
I would also add "." for python/namespace-specific tags like os.popen

http://codereview.appspot.com/40100/diff/4/1001#newcode12
Line 12: # XXX Should we convert the name to lowercase or let the error happen?
lowercase and probably convert CamelCased names to under_scored automatically

http://codereview.appspot.com/40100/diff/4/1001#newcode26
Line 26: tags = [tag.strip() for tag in tags.split(',')]
as our tags can not contain spaces, spaces would do better for separating tags
than commas

http://codereview.appspot.com/40100/diff/4/1001#newcode38
Line 38: tag_ids.append(tid)
shouldn't there be calls to history component to record/notify when tags are
added/removed or this is done automatically by roundup?

http://codereview.appspot.com/40100/diff/4/1005
File instances/python-dev/schema.py (right):

http://codereview.appspot.com/40100/diff/4/1005#newcode130
Line 130: tags_str=String()
why not just tags and make it a sorted list?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5