Issue 40100: Issue tags for the Python bug tracker

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 40100: Issue tags for the Python bug tracker

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by ajaksu

Modified:
15 years, 5 months ago

Reviewers:
techtonik

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Correct diff #

Total comments: 5

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -5 lines)			Patch
A	instances/python-dev/detectors/tagsauditor.py	View		1 chunk	+59 lines, -0 lines	4 comments	Download
M	instances/python-dev/html/issue.index.html	View	1	4 chunks	+52 lines, -0 lines	0 comments	Download
M	instances/python-dev/html/issue.item.html	View		2 chunks	+27 lines, -0 lines	0 comments	Download
M	instances/python-dev/html/issue.search.html	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	instances/python-dev/schema.py	View		8 chunks	+21 lines, -5 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

techtonik

15 years, 5 months ago (2009-06-08 13:11:46 UTC) #1

I am not able to test interface itself, so I've just played a bit with this
awesome review tool.

http://codereview.appspot.com/40100/diff/4/1001
File instances/python-dev/detectors/tagsauditor.py (right):

http://codereview.appspot.com/40100/diff/4/1001#newcode6
Line 6: ALLOWED_CHARS = '[a-z_-]+$'
I would also add "." for python/namespace-specific tags like os.popen

http://codereview.appspot.com/40100/diff/4/1001#newcode12
Line 12: # XXX Should we convert the name to lowercase or let the error happen?
lowercase and probably convert CamelCased names to under_scored automatically

http://codereview.appspot.com/40100/diff/4/1001#newcode26
Line 26: tags = [tag.strip() for tag in tags.split(',')]
as our tags can not contain spaces, spaces would do better for separating tags
than commas

http://codereview.appspot.com/40100/diff/4/1001#newcode38
Line 38: tag_ids.append(tid)
shouldn't there be calls to history component to record/notify when tags are
added/removed or this is done automatically by roundup?

http://codereview.appspot.com/40100/diff/4/1005
File instances/python-dev/schema.py (right):

http://codereview.appspot.com/40100/diff/4/1005#newcode130
Line 130: tags_str=String()
why not just tags and make it a sorted list?

Expand All Messages | Collapse All Messages