Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(945)

Issue 4005047: code review 4005047: godoc: tiny bug fix - use correct filename when compari... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by gri
Modified:
14 years, 1 month ago
Reviewers:
CC:
rsc, r2, golang-dev
Visibility:
Public.

Description

godoc: tiny bug fix - use correct filename when comparing files against the index whitelist This bug prevented files such as READMEs etc. from being included in the index. For instance, now author names recorded in the AUTHORS file can be found with a godoc query.

Patch Set 1 #

Patch Set 2 : code review 4005047: godoc: tiny bug fix - use correct filename when compari... #

Patch Set 3 : code review 4005047: godoc: tiny bug fix - use correct filename when compari... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/cmd/godoc/index.go View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 1 month ago (2011-01-27 22:07:13 UTC) #1
r2
LGTM but s/agains/against/ in the CL description
14 years, 1 month ago (2011-01-27 22:10:21 UTC) #2
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=2dd3964e1716 *** godoc: tiny bug fix - use correct filename when comparing ...
14 years, 1 month ago (2011-01-27 22:12:00 UTC) #3
gri
14 years, 1 month ago (2011-01-27 22:12:11 UTC) #4
On Thu, Jan 27, 2011 at 2:10 PM, Rob 'Commander' Pike <r@google.com> wrote:

> LGTM but s/agains/against/ in the CL description
>
> fixed and submitted
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b